Skip to content

Remove goto #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2023
Merged

Remove goto #1838

merged 2 commits into from
May 23, 2023

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented May 20, 2023

towards #1826 (comment)

closes #1144

@ubaidsk ubaidsk requested a review from certik May 20, 2023 07:33
@ubaidsk ubaidsk mentioned this pull request May 20, 2023
Merged
@certik
Copy link
Contributor

certik commented May 22, 2023

Thanks! I will get back to you on this, for now let's keep it open.

@ubaidsk ubaidsk marked this pull request as draft May 22, 2023 15:29
@certik
Copy link
Contributor

certik commented May 22, 2023

Ok, it looks like we can remove it. Let's do it after the ASR sync.

If in the future we nee to put this back in, it would not be complicated.

@ubaidsk ubaidsk marked this pull request as ready for review May 23, 2023 05:55
@ubaidsk ubaidsk requested a review from czgdp1807 May 23, 2023 06:00
@czgdp1807 czgdp1807 enabled auto-merge (squash) May 23, 2023 06:34
@czgdp1807 czgdp1807 merged commit d9163ab into lcompilers:main May 23, 2023
@ubaidsk ubaidsk deleted the remove_goto branch May 23, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik Awaiting requested review from certik

@czgdp1807 czgdp1807 Awaiting requested review from czgdp1807

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to implement GoTo
3 participants
@ubaidsk @certik @czgdp1807